fix: update to verify path exists before chdir in configAggProvider #4517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbockus-sf
commented
Oct 26, 2022
| @@ -82,12 +82,14 @@ export class ConfigAggregatorProvider { | |||
|
|
|||
| private ensureCurrentDirectoryInsideProject(path: string) { | |||
| const rootWorkspacePath = workspaceUtils.getRootWorkspacePath(); | |||
| if (path !== rootWorkspacePath) { | |||
There was a problem hiding this comment.
So the issue here is when we have an empty project state the rootWorkspacePath is ''. If we attempt to call process.chdir('') it throws an error and bails. It seemed reasonable to not attempt the chdir is we don't have a valid path. Def a little paranoid that we'll end up with a global config agg when we don't want it.
klewis-sfdc
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the config agg provider to not attempt to chdir when the current working directory is undefined or empty string.
What issues does this PR fix or reference?
#4465
Functionality Before
Functionality After
Successful creation of a new project from the empty project state.