Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set home as save path for unsaved query results #4742

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

jgellin-sf
Copy link
Contributor

What does this PR do?

By default, SOQL query results are saved to the same directory as the .soql file from which the query is generated. However, when the SOQL query is not yet saved, the default directory was set to the root. This PR changes the behavior so that the default directory for unsaved query results is set to the home directory instead of the root.

What issues does this PR fix or reference?

forcedotcom/code-builder-feedback#201
@W-12081773@

Functionality Before

View query results of unsaved SOQL query. Save as CSV or JSON. The save dialog shows the root directory as the default save directory.

Functionality After

View query results of unsaved SOQL query. Save as CSV or JSON. The save dialog shows the home directory as the default save directory.

Copy link
Contributor

@floralan floralan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Good job! 👍

@jgellin-sf jgellin-sf merged commit e31a594 into develop Mar 16, 2023
@jgellin-sf jgellin-sf deleted the jg/save-untitled-soql-query-results-to-home branch March 16, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants