Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/4761 #4784

Merged
merged 5 commits into from
Apr 5, 2023
Merged

Pr/4761 #4784

merged 5 commits into from
Apr 5, 2023

Conversation

CristiCanizales
Copy link
Contributor

What does this PR do?

This PR adds ExperiencePropertyType to the metadata dictionary. Similar to the wave template, the ExperiencePropertyType metadata type doesn't have a -meta.xml instead it has a static schema.json file for each metadata. Adding an entry to the metadata dictionary to fix this issue

What issues does this PR fix or reference?

#4761 , @W-12980533@

Functionality Before

  • Retrieving ExperiencePropertyType throws an error and doesn't show the overwrite popup when metadata locally exists

Functionality After

  • Retrieving ExperiencePropertyType shows overwrite popup warning if it exists locally and no error is thrown when retrieving this type

Copy link
Contributor

@gbockus-sf gbockus-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp 👍

@CristiCanizales CristiCanizales merged commit cb6f8cc into develop Apr 5, 2023
@CristiCanizales CristiCanizales deleted the pr/4761 branch April 5, 2023 22:31
@CristiCanizales
Copy link
Contributor Author

Thank you for your contribution @Kaaviyan ! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants