Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add "Prefer deploy on save" setting #4820

Merged
merged 28 commits into from
May 15, 2023
Merged

feat: Add "Prefer deploy on save" setting #4820

merged 28 commits into from
May 15, 2023

Conversation

klewis-sfdc
Copy link
Contributor

@klewis-sfdc klewis-sfdc commented Apr 21, 2023 •
edited
Loading

What does this PR do?

  • Adds a setting that will run a deploy instead of a push when "Push or deploy on save" is enabled.

What issues does this PR fix or reference?

#4813, @W-13083377@

Functionality Before

  • When "Push or deploy on save" is enabled, push is run on save for source-tracked orgs.

Functionality After

  • When

    • "Push or deploy on save" is enabled and
    • "Prefer deploy on save" is disabled,
      • push is run on save for source-tracked orgs.

  • When

    • "Push or deploy on save" is enabled and
    • "Prefer deploy on save" is enabled,
      • deploy is run.

2023-04-21_16-53-19

@klewis-sfdc klewis-sfdc force-pushed the ken/W-11309172--deploy-retrieve-scratch-orgs branch 2 times, most recently from 198e6d1 to 83ed0fe Compare April 25, 2023 23:32
@klewis-sfdc klewis-sfdc force-pushed the ken/W-11309172--deploy-retrieve-scratch-orgs branch from 83ed0fe to d74b429 Compare April 25, 2023 23:33
@klewis-sfdc klewis-sfdc force-pushed the ken/prefer-deploy-on-save-setting branch 2 times, most recently from d2c5ab7 to d9c4a48 Compare April 26, 2023 22:13
@klewis-sfdc klewis-sfdc force-pushed the ken/prefer-deploy-on-save-setting branch from d9c4a48 to 350401d Compare April 26, 2023 22:35
Base automatically changed from ken/W-11309172--deploy-retrieve-scratch-orgs to develop May 3, 2023 22:44
@klewis-sfdc klewis-sfdc marked this pull request as ready for review May 3, 2023 23:39
@klewis-sfdc klewis-sfdc requested a review from a team as a code owner May 3, 2023 23:39
@CristiCanizales CristiCanizales linked an issue May 9, 2023 that may be closed by this pull request
Unable to deploy on save (only push, but I don't want that) #4813
Closed
CristiCanizales
CristiCanizales approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@CristiCanizales CristiCanizales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
I verified it:

  • pushes if the preference is not enabled ✅
  • deploys if the preference is enabled ✅
    Thanks for this Ken! 😄

@klewis-sfdc klewis-sfdc merged commit 54622ec into develop May 15, 2023
@klewis-sfdc klewis-sfdc deleted the ken/prefer-deploy-on-save-setting branch May 15, 2023 20:12
This was referenced May 18, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CristiCanizales CristiCanizales CristiCanizales approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to deploy on save (only push, but I don't want that)
2 participants
@klewis-sfdc @CristiCanizales