fix: Org browser ignores sfdx project.json api version #4891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…api-version-draft
…api-version-draft
…api-version-draft
…api-version-draft
…api-version-draft
…api-version-draft
…api-version-draft
jeffb-sfdc
changed the title
…api-version-draft
|
QA notes
✅ sourceApiVersion specified in sfdx-project.json takes precedence over local config while
|
RitamAgrawal
approved these changes
Jun 6, 2023
…api-version-draft
jeffb-sfdc
deleted the
jb/org-browser-ignores-sfdx-project.json-api-version-draft
branch
jeffb-sfdc
changed the title
jeffb-sfdc
changed the title
jeffb-sfdc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
#3663, @W-10273533@
Functionality Before
Deploying and retrieving was not adhering to the API rules defined at https://developer.salesforce.com/docs/atlas.en-us.sfdx_setup.meta/sfdx_setup/sfdx_setup_apiversion.htm
Functionality After
Deploy and retrieve now use
setApiVersion()(in packages/salesforcedx-vscode-core/src/services/sdr/componentSetUtils.ts) to define which API to use.NOTE: This is the exact PR as #4801 (and no changes between the two). PR #4801 was merged but needed to be backed out.