-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace sfdx to sf style flag name #4993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!😄 bootstrapCmd.test.ts
should be updated accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a small comment regarding a flag
@@ -202,7 +202,7 @@ describe('ISV Debugging Project Bootstrap Command', () => { | |||
} | |||
); | |||
expect(command.toCommand()).to.equal( | |||
`sfdx force:data:soql:query --query SELECT NamespacePrefix FROM Organization LIMIT 1 --targetusername ${SESSION_ID} --json --loglevel fatal` | |||
`sfdx data query --query SELECT NamespacePrefix FROM Organization LIMIT 1 --target-org ${SESSION_ID} --json --loglevel fatal` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And in that case change/remove it here too
packages/salesforcedx-vscode-core/src/commands/isvdebugging/bootstrapCmd.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
What does this PR do?
Upgrades deprecated cli flags to new flags.
Removes warnings while setting up the ISV debugger
What issues does this PR fix or reference?
#, @W-13834204@
Changes
Functionality After
Cli warnings should go away
Docs for reference: https://developer.salesforce.com/docs/atlas.en-us.sfdx_cli_reference.meta/sfdx_cli_reference/cli_reference_force_mdapi.htm#cli_reference_force_mdapi_retrieve