Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace sfdx to sf style flag name #4993

Merged
merged 5 commits into from
Jul 31, 2023

Conversation

RitamAgrawal
Copy link
Member

@RitamAgrawal RitamAgrawal commented Jul 27, 2023

What does this PR do?

Upgrades deprecated cli flags to new flags.
Removes warnings while setting up the ISV debugger

What issues does this PR fix or reference?

#, @W-13834204@

Changes

Old style New style
--outputdir --output-dir
--projectname --name
--targetusername --target-org
--retrievetargetdir --target-metadata-dir
--unpackaged --manifest
--packagenames --package-name
isvDebuggerSid org-isv-debugger-sid
isvDebuggerUrl org-isv-debugger-url
instanceUrl org-instance-url

Functionality After

Cli warnings should go away

Docs for reference: https://developer.salesforce.com/docs/atlas.en-us.sfdx_cli_reference.meta/sfdx_cli_reference/cli_reference_force_mdapi.htm#cli_reference_force_mdapi_retrieve

@RitamAgrawal RitamAgrawal requested a review from a team as a code owner July 27, 2023 00:39
Copy link
Contributor

@CristiCanizales CristiCanizales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!😄 bootstrapCmd.test.ts should be updated accordingly

Copy link
Contributor

@CristiCanizales CristiCanizales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small comment regarding a flag

@@ -202,7 +202,7 @@ describe('ISV Debugging Project Bootstrap Command', () => {
}
);
expect(command.toCommand()).to.equal(
`sfdx force:data:soql:query --query SELECT NamespacePrefix FROM Organization LIMIT 1 --targetusername ${SESSION_ID} --json --loglevel fatal`
`sfdx data query --query SELECT NamespacePrefix FROM Organization LIMIT 1 --target-org ${SESSION_ID} --json --loglevel fatal`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And in that case change/remove it here too

Copy link
Contributor

@CristiCanizales CristiCanizales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@RitamAgrawal RitamAgrawal merged commit 3a978a9 into develop Jul 31, 2023
12 checks passed
@RitamAgrawal RitamAgrawal deleted the ra/isv_debugger_setup_step4 branch July 31, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants