Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove sfdx variable defaultdevhubusername #5005

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

daphne-sfdc
Copy link
Contributor

@daphne-sfdc daphne-sfdc commented Aug 1, 2023

What does this PR do?

The variable "defaultdevhubusername" is no longer in use in the codebase. This PR is a code cleanup that removes all the places in the code where "defaultdevhubusername" is referenced.

What issues does this PR fix or reference?

Gus work item: [@W-13864595@] (https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00001XNs7vYAD/view)

Functionality Before/After

No change in functionality - this PR removes extraneous code that is no longer in use.

@daphne-sfdc daphne-sfdc requested a review from a team as a code owner August 1, 2023 15:28
@daphne-sfdc daphne-sfdc requested a review from lukeis August 1, 2023 15:28
@CristiCanizales CristiCanizales requested review from CristiCanizales and removed request for lukeis August 1, 2023 15:39
Copy link
Contributor

@CristiCanizales CristiCanizales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!
I tested with the VSIX from this PR that everything related to a dev hub is still working as expected ✅

@daphne-sfdc daphne-sfdc merged commit 8088523 into develop Aug 2, 2023
12 checks passed
@daphne-sfdc daphne-sfdc deleted the daphne/remove-defaultdevhubusername branch August 2, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants