Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ra/isv remove zip retrieval #5038

Merged
merged 32 commits into from
Aug 31, 2023
Merged

Ra/isv remove zip retrieval #5038

merged 32 commits into from
Aug 31, 2023

Conversation

RitamAgrawal
Copy link
Member

@RitamAgrawal RitamAgrawal commented Aug 21, 2023 •
edited
Loading

What does this PR do?

  • Fixes SFDX: Create and Set up project for ISV Debugging
  • Removes step 4 and 7 where conversion of metadata formatted retrieved files were happening.
  • Earlier Retrieving was a two-step process: First retrieve in zip format and then convert it in next step. Now retrieving apex classes, triggers & packages in one single step whenever needed.

What issues does this PR fix or reference?

#5032, @W-13915883@

Functionality Before

  • Retrieves in metadata format and then convert it to source format.
  • Total number of steps appearing on output channel was 7

Functionality After

  • Retrieves in one single format
  • Total number of steps appearing on output channel is 5

RitamAgrawal and others added 19 commits August 8, 2023 18:17
@RitamAgrawal RitamAgrawal marked this pull request as ready for review August 29, 2023 04:08
@RitamAgrawal RitamAgrawal requested a review from a team as a code owner August 29, 2023 04:08
RitamAgrawal and others added 2 commits August 30, 2023 11:28
@RitamAgrawal @peternhale
chore: update replace
1fcebd4 
Co-authored-by: peternhale <peternhale@users.noreply.github.com>
@RitamAgrawal
chore: update replace arg
724fb21
@peternhale peternhale self-requested a review August 31, 2023 12:31
gbockus-sf
gbockus-sf approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@gbockus-sf gbockus-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@RitamAgrawal RitamAgrawal merged commit 4fb28aa into develop Aug 31, 2023
12 checks passed
@RitamAgrawal RitamAgrawal deleted the ra/isv_remove_zip_retrieval branch August 31, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbockus-sf gbockus-sf gbockus-sf approved these changes

@peternhale peternhale peternhale approved these changes

@lahernandezb lahernandezb Awaiting requested review from lahernandezb lahernandezb is a code owner automatically assigned from forcedotcom/ide-experience

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RitamAgrawal @peternhale @gbockus-sf