Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change delete source commands and flags to sf style #5060

Merged
merged 5 commits into from
Sep 19, 2023

Conversation

CristiCanizales
Copy link
Contributor

@CristiCanizales CristiCanizales commented Aug 30, 2023

What does this PR do?

  • Updates Delete Source commands and flags to SF style in order to get rid of cli warnings

What issues does this PR fix or reference?

@W-14047399@

Changes

  • force:source:deleteproject:delete:source
  • --sourcepath--source-dir
  • --noprompt--no-prompt
  • --tracksource--track-source
  • SFDX_JSON_TO_STDOUTSF_JSON_TO_STDOUT

Warnings before

(node:90713) Warning: Deprecated environment variable: SFDX_JSON_TO_STDOUT. Please use SF_JSON_TO_STDOUT instead.
(Use `node —trace-warnings ...` to show where the warning was created)
Warning: The "force source delete" command has been deprecated. Use "project delete source" instead.
Warning: The "—sourcepath" flag has been deprecated. Use "—source-dir | -p" instead.
Warning: The "—noprompt" flag has been deprecated. Use "—no-prompt | -r" instead

Reference: https://developer.salesforce.com/docs/atlas.en-us.sfdx_cli_reference.meta/sfdx_cli_reference/cli_reference_force_source.htm#cli_reference_force_source_delete

Copy link
Member

@RitamAgrawal RitamAgrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Holding on to Approval. Let's merge it after the release

};
const flagStatusRemote: FlagParameter<SourceStatusFlags> = {
flag: SourceStatusFlags.Remote
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused constants!

Copy link
Member

@RitamAgrawal RitamAgrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 Removed unused constants and imports.
Replacement of old sfdx with sf style cli-commands and renaming the variable names accordingly.

@CristiCanizales CristiCanizales merged commit 3df63eb into develop Sep 19, 2023
11 checks passed
@CristiCanizales CristiCanizales deleted the cristi/delete-source-warnings branch September 19, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants