-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change delete source commands and flags to sf style #5060
Conversation
packages/salesforcedx-vscode-core/test/jest/commands/delete/projectDeleteSource.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Holding on to Approval. Let's merge it after the release
}; | ||
const flagStatusRemote: FlagParameter<SourceStatusFlags> = { | ||
flag: SourceStatusFlags.Remote | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused constants!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 Removed unused constants and imports.
Replacement of old sfdx with sf style cli-commands and renaming the variable names accordingly.
What does this PR do?
What issues does this PR fix or reference?
@W-14047399@
Changes
force:source:delete
⇢project:delete:source
--sourcepath
⇢--source-dir
--noprompt
⇢--no-prompt
--tracksource
⇢--track-source
SFDX_JSON_TO_STDOUT
⇢SF_JSON_TO_STDOUT
Warnings before
Reference: https://developer.salesforce.com/docs/atlas.en-us.sfdx_cli_reference.meta/sfdx_cli_reference/cli_reference_force_source.htm#cli_reference_force_source_delete