Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct structural eslint error #5243

Merged
merged 33 commits into from
Nov 29, 2023
Merged

fix: correct structural eslint error #5243

merged 33 commits into from
Nov 29, 2023

Conversation

peternhale
Copy link
Contributor

Corrects structural eslint issues across all packages.

@W-14455533@

@peternhale peternhale requested a review from a team as a code owner November 20, 2023 21:25
@peternhale peternhale marked this pull request as draft November 20, 2023 22:20
@peternhale peternhale marked this pull request as ready for review November 21, 2023 17:12
@@ -79,6 +79,7 @@ export const vscodeStub = {
withProgress: () => {
return Promise.resolve(true);
},
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phew...thought this might be a lot more.

Copy link
Contributor

@gbockus-sf gbockus-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks Pete! I view this PR as a if it builds it builds situation. Lemme know if you think it needs deeper QE.

@peternhale peternhale merged commit daa487e into develop Nov 29, 2023
@peternhale peternhale deleted the phale/fix-lint branch November 29, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants