Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate from @salesforce/core v5 -> v6 #5332

Merged
merged 12 commits into from
Jan 12, 2024

Conversation

daphne-sfdc
Copy link
Contributor

@daphne-sfdc daphne-sfdc commented Jan 11, 2024

What does this PR do?

Migrates @salesforce/core from v5.3.0 -> v6.4.7

This upgrade means we are able to support Core v6 in our other dependencies, so the following dependencies are also migrated from Core v5 -> v6 in this PR:

  1. @salesforce/source-deploy-retrieve - v9.8.4 -> v10.2.9
  2. @salesforce/source-tracking - v4.3.0 -> v5.1.3
  3. @salesforce/apex-node - v2.1.6 -> v3.0.1
  4. @salesforce/templates - v59.0.4 -> v60.1.0
  5. jsforce - v2.0.0-beta.28 -> v2.0.0-beta.29

What issues does this PR fix or reference?

@W-14671437@

Functionality Before

Extensions monorepo uses v5 of @salesforce/core

Functionality After

Extensions monrepo uses v6 of @salesforce/core, which means we are now able to pull in new features from our shared libraries

@daphne-sfdc daphne-sfdc requested a review from a team as a code owner January 11, 2024 19:10
@@ -10,9 +10,9 @@
},
"main": "out/src",
"dependencies": {
"@salesforce/core": "5.3.20",
"@salesforce/core": "6.4.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daphne-sfdc please bump this to the most recent version of v6. I know its a moving target, but lets try to get this merged being as close to current as possible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should visit all of the one to see if they have been bumped

@mingxuanzhangsfdx
Copy link
Member

I tested it manually and it looks good.

@mingxuanzhangsfdx mingxuanzhangsfdx merged commit 72f5c2e into develop Jan 12, 2024
12 checks passed
@mingxuanzhangsfdx mingxuanzhangsfdx deleted the daphne/core-v5-v6 branch January 12, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants