fix: startupTime telemetry metrics for apex debugger & replay debugger #5341
Conversation
| @@ -52,8 +57,8 @@ export class TelemetryService { | |||
| } | |||
| } | |||
|
|
|||
| private getEndHRTime(hrstart: [number, number]): string { | |||
| private getEndHRTime(hrstart: [number, number]): number { | |||
There was a problem hiding this comment.
what does this change do and what impact does it have on telemetry?
There was a problem hiding this comment.
was this the root cause of the issue?
There was a problem hiding this comment.
public sendTelemetryEvent( eventName: string, properties?: { [key: string]: string }, measurements?: { [key: string]: number } ): void
startupTime should be passed in via measurements, so that it can be viewed as a log metrics. So I need to change the function to return a number type. So measurements has a parameter like this:
{ 'startupTime': 1 }
|
Thanks Mingxuan! How can this be tested locally? |
@diyer We run extensions with the change, and we should be able to see the metrics on azure after a while, which means when we specify the metrics startupTime and we set up the filter for extensionName, apex debugger & replay debugger shows up. I will do that after training. |
mingxuanzhangsfdx
changed the title
What does this PR do?
startupTime was not a metrics in apex debugger & replay debugger, which makes it impossible to measure in the two extensions. This PR makes startupTime a measurement so we are able to view the metrics in azure appinsights.
What issues does this PR fix or reference?
@W-14834514@
Functionality Before
startupTime in apex debugger & replay debugger is not a log metrics.
Functionality After
startupTime in apex debugger & replay debugger is a log metrics.