fix: check java version was criteria was ambiguous #5363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@W-14888195@ Modified the check to include java option `XshowSettings:properties`
peternhale
commented
Jan 25, 2024
peternhale
commented
Jan 25, 2024
peternhale
commented
Jan 25, 2024
There was a problem hiding this comment.
Moved the test from integration to jest.
daphne-sfdc
approved these changes
Jan 25, 2024
handle the error from the callback if presnet. Issue better message
daphne-sfdc
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Approved! 🎉
Test Cases (run using VSIXs generated from Commit Workflow):
- Leave the Java Home setting blank -> Java Home should take the value of the $JAVA_HOME environment variable set locally ✅ (this was working as expected for Pete but Daphne has a system issue)
- Invalid Java version (Java 21) -> should get
wrong_java_version_texterror message ✅ - Path to random empty folder -> should get
wrong_java_version_texterror message ✅ - Salesforce-approved Java 11 use for Core development ✅
- Zulu Java 17 ✅
- Oracle Java 17 ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the check to include java option
XshowSettings:propertiesWhat does this PR do?
What issues does this PR fix or reference?
@W-14888195@ #5358
Functionality Before
The validation of java version used a string match for
build 17.and the customer's java version reportedbuild 17+causing a false positive when check version during startupFunctionality After
The validation function has been changed to run the java version command with an option that displays all of the assign System properties the JVM will be using. One of the is
java.version = nn[.nn[.nn]]. This representation is more reliable that using thebuildstring from the java version command.