Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate org browser cmds from sfdx to sf #5379

Merged
merged 10 commits into from
Feb 6, 2024

Conversation

peternhale
Copy link
Contributor

@W-14720794@
Migrates the org browser feature to use sf styled commands to accomplish the needs of org browser.

There no no changes to the functionality.

In addition to changing the underlying sfdx commands that are called these changes were made

  • ForceDescribeMetadataExecutor → DescribeMetadataExecutor
  • ForceListMetadataExecutor → ListMetadataExecutor
  • force:mdapi:describemetadata → org list metadata-types
  • force:mdapi:listmetadata → org list metadata
  • forceDescribeMetadata → describeMetadata

@peternhale peternhale requested a review from a team as a code owner January 29, 2024 14:09
Copy link
Contributor

@CristiCanizales CristiCanizales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some pending changes and then I'll do the QE 🙂

Copy link
Contributor

@CristiCanizales CristiCanizales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last remaining stuff that just came to me
image

Copy link
Contributor

@CristiCanizales CristiCanizales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Pete 🙂
Org Browser continues working as before :)

  • Retrieve ✅
  • Refresh ✅

:shipit:

@peternhale peternhale merged commit c8b85c5 into develop Feb 6, 2024
12 checks passed
@peternhale peternhale deleted the phale/W-14720794-org-browser-to-sf branch February 6, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants