Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: push error handling #5392

Merged
merged 4 commits into from
Feb 3, 2024
Merged

fix: push error handling #5392

merged 4 commits into from
Feb 3, 2024

Conversation

CristiCanizales
Copy link
Contributor

What does this PR do?

  • Fixes error handling for push command

What issues does this PR fix or reference?

@W-14717018@

Functionality Before

  • no output after a failed push

Functionality After

  • correct output after a failed push

@@ -16,34 +16,34 @@ import { SfdxCommandletExecutor } from '../commands/util';

const notApplicable = 'N/A';

export function getFileUri(
export const getFileUri = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrow functions! Thank you!

Copy link
Contributor

@daphne-sfdc daphne-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🎉

Commands tested:

• SFDX: Push Source to Default Org (push to empty scratch org) ✅
• SFDX: Push Source to Default Org (pushed no changed files successfully) ✅
• SFDX: Push Source to Default Org (change a file in local, no conflicts) ✅
• SFDX: Push Source to Default Org (change a file in org, no conflicts) ✅
Note: Since I did not pull the file after changing it in the org, I expected the file to be reverted to what I had in local when I ran the push because that's what happens when I run deploy. But this was the behavior in the currently published version v59.16.0 so I'm going with what's there.
Screenshot 2024-02-02 at 11 44 17 PM
• SFDX: Push Source to Default Org (failed because of a conflict) ✅
Screenshot 2024-02-02 at 11 42 47 PM

• SFDX: Push Source to Default Org (push to empty scratch org) ✅
• SFDX: Push Source to Default Org and Ignore Conflicts (pushed no changed files successfully) ✅
• SFDX: Push Source to Default Org and Ignore Conflicts (change a file in local, no conflicts) ✅
• SFDX: Push Source to Default Org and Ignore Conflicts (change a file in org, no conflicts) ✅
Note: Same as above. Not the behavior that I would expect, but accepting it because it's the original behavior.
Screenshot 2024-02-02 at 11 53 21 PM
• SFDX: Push Source to Default Org and Ignore Conflicts (overrode a conflict successfully) ✅
Screenshot 2024-02-02 at 11 54 24 PM

@daphne-sfdc daphne-sfdc merged commit e19f720 into develop Feb 3, 2024
12 checks passed
@daphne-sfdc daphne-sfdc deleted the cristi/fix-push-diagnostics branch February 3, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants