fix: sfdx to sf for auth access token, generate manifest and rename lwc component #5409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternhale
approved these changes
Feb 9, 2024
CristiCanizales
changed the title
daphne-sfdc
reviewed
Feb 12, 2024
| @@ -70,5 +71,6 @@ | |||
| "stop_apex_debug_logging": "SFDX: Replay Debugger 用の Apex デバッグログを無効化", | |||
| "telemetry_enabled_description": "Salesforce による利用状況データの収集を有効化するかどうかを指定します。この設定で有効化していても、VS Code 全体の設定 `telemetry.enableTelemetry` が優先されます。", | |||
| "visualforce_generate_component_text": "SFDX: Visualforce コンポーネントを作成", | |||
| "visualforce_generate_page_text": "SFDX: Visualforce ページを作成" | |||
| "visualforce_generate_page_text": "SFDX: Visualforce ページを作成", | |||
| "rename_lightning_component_text": "SFDX: Rename Component" | |||
There was a problem hiding this comment.
Interesting that this used to be only present in the English file and not the Japanese one - good catch!
daphne-sfdc
reviewed
Feb 12, 2024
...s/salesforcedx-vscode-core/test/vscode-integration/commands/renameLightningComponent.test.ts
Outdated
Show resolved
Hide resolved
…ands/renameLightningComponent.test.ts Co-authored-by: Daphne Yang <139700604+daphne-sfdc@users.noreply.github.com>
daphne-sfdc
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Approved! 🎉
Commands Tested:
• SFDX: Authorize an Org Using Session ID – successful case ✅
• SFDX: Authorize an Org Using Session ID – error case (invalid session ID) prints error message in Output tab ✅
• SFDX: Generate Manifest File – successful case ✅
• SFDX: Generate Manifest File – error case (anonymous Apex file) prints error message in Output tab ✅
• SFDX: Rename Component – successful case (LWC) ✅
• SFDX: Rename Component – successful case (Aura) ✅
• SFDX: Rename Component – error case (name does not start with letter) prints error message in Output tab ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
@W-14720800@