Mz/w 14720788/diff refresh to sf #5418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CristiCanizales
requested review from
CristiCanizales
and removed request for
smarvez
| defaultUsernameorAlias, | ||
| filePart, | ||
| filePart | ||
| ) | ||
| ); | ||
| } catch (err) { | ||
| notificationService.showErrorMessage(err.message); | ||
| await notificationService.showErrorMessage(err.message); |
There was a problem hiding this comment.
why this await? the function doesn't return a promise
There was a problem hiding this comment.
From what I learnt, the return type Thenable also needs await. My vscode lint check also reminds me to do so.
| telemetryService.sendException('unsupported_type_on_diff', errorMessage); | ||
| notificationService.showErrorMessage(errorMessage); | ||
| await notificationService.showErrorMessage(errorMessage); |
| @@ -38,13 +38,15 @@ export async function forceSourceDiff(sourceUri?: vscode.Uri) { | |||
|
|
|||
| const defaultUsernameorAlias = WorkspaceContext.getInstance().username; | |||
| if (!defaultUsernameorAlias) { | |||
| notificationService.showErrorMessage(nls.localize('missing_default_org')); | |||
| await notificationService.showErrorMessage( | |||
| telemetryService.sendException('unsupported_type_on_diff', errorMessage); | ||
| notificationService.showErrorMessage(errorMessage); | ||
| await notificationService.showErrorMessage(errorMessage); |
| @@ -72,7 +74,9 @@ export async function forceSourceFolderDiff(explorerPath: vscode.Uri) { | |||
|
|
|||
| const username = WorkspaceContext.getInstance().username; | |||
| if (!username) { | |||
| notificationService.showErrorMessage(nls.localize('missing_default_org')); | |||
| await notificationService.showErrorMessage( | |||
|
QE notes:
|
CristiCanizales
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change the style of diff files, folders & refresh sobject to sf
What issues does this PR fix or reference?
@W-14720788@
Functionality Before
sfdx style
Functionality After
sf style