Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update vscode engine to 1.82.0 #5446

Merged
merged 4 commits into from
Feb 23, 2024
Merged

fix: update vscode engine to 1.82.0 #5446

merged 4 commits into from
Feb 23, 2024

Conversation

peternhale
Copy link
Contributor

@W-15091730@

Updates the vscode engine version to 1.82.0 or greater

There should be not change in functionality

@peternhale peternhale requested a review from a team as a code owner February 22, 2024 20:09
daphne-sfdc
daphne-sfdc approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@daphne-sfdc daphne-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🎉

Confirmed that there are no more warnings under Problems tab when all package.json files are opened ✅

E2E test runs:

  • E2E Tests Run #811: VSCode version 1.85.2 is able to pass all E2E tests ✅
  • Base Suite Run #9: VSCode version 1.82.3 is able to pass all base suite E2E tests ✅
  • Base Suite Run #10: VSCode version 1.81.1 is no longer supported - extensions cannot activate and SFDX: Create Project cannot be run ✅

@peternhale peternhale merged commit eec5772 into develop Feb 23, 2024
12 checks passed
@peternhale peternhale deleted the phale/W-15091730-update-engines branch February 23, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daphne-sfdc daphne-sfdc daphne-sfdc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peternhale @daphne-sfdc