fix: bump apex-node apply json dangling comma bug #5537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@W-15471840@
daphne-sfdc
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Approved! 🎉
After installing the VSIXs from the commit workflow of this PR:
- No more dangling commas in test-result.json files and no problems in the Problems tab ✅
- Code coverage highlighting is working as expected with no error messages in the Output tab ✅
E2E run: https://github.com/forcedotcom/salesforcedx-vscode/actions/runs/8666814783 ✅ (failures are flappers)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug introduced in apex-node that did not properly manage dangling commas in apex test results
@W-15471840@
#5534
Functionality Before
See issue
Functionality After
Enabling code coverage highlighting functions properly.