Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump apex-node for dangling comma fix #5543

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

peternhale
Copy link
Contributor

pick up latest v4 version of apex-node to correct test result parsing error when no code coverage is in test results.

What does this PR do?

What issues does this PR fix or reference?

#5534 , @W-15530915@

Functionality Before

When using the highlight code coverage feature and running apex tests without code coverage, extensions were displaying an message stating coverage results parsing failed. This is due to a bug introduced in apex-node streaming changes in v60.8.0.

Functionality After

The fix to apex-node corrected the JSON results used for highlighting code coverage, when there is not code coverage present, no produces the correct warning that no code coverage is present in the latest test run for the apex class opened in the editor.

@W-15530915@
pick up latest v4 version of apex-node
@peternhale peternhale requested a review from a team as a code owner April 18, 2024 13:31
Copy link
Contributor

@daphne-sfdc daphne-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🎉

Confirmed that there are no dangling commas in test-result.json files both when code coverage setting is checked and unchecked, and code coverage highlighting is present. Works on both Mac and Windows. ✅

QE notes at the bottom of this doc: https://salesforce.quip.com/DXmnAhMNNOBZ

@peternhale peternhale merged commit a853d1f into develop Apr 18, 2024
12 checks passed
@peternhale peternhale deleted the phale/W-15530915-dangling-comma-fix branch April 18, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants