fix: bump apex-node for dangling comma fix #5543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@W-15530915@ pick up latest v4 version of apex-node
daphne-sfdc
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Approved! 🎉
Confirmed that there are no dangling commas in test-result.json files both when code coverage setting is checked and unchecked, and code coverage highlighting is present. Works on both Mac and Windows. ✅
QE notes at the bottom of this doc: https://salesforce.quip.com/DXmnAhMNNOBZ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pick up latest v4 version of apex-node to correct test result parsing error when no code coverage is in test results.
What does this PR do?
What issues does this PR fix or reference?
#5534 , @W-15530915@
Functionality Before
When using the highlight code coverage feature and running apex tests without code coverage, extensions were displaying an message stating coverage results parsing failed. This is due to a bug introduced in apex-node streaming changes in v60.8.0.
Functionality After
The fix to apex-node corrected the JSON results used for highlighting code coverage, when there is not code coverage present, no produces the correct warning that no code coverage is present in the latest test run for the apex class opened in the editor.