fix: no throw on unknown config value

forcedotcom · Feb 11, 2021 · 49618db · 49618db
1 parent b214da3
commit 49618db
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/config/config.ts b/src/config/config.ts
@@ -425,7 +425,7 @@ export class Config extends ConfigFile<ConfigFile.Options> {
    */
   private async cryptProperties(encrypt: boolean): Promise<void> {
     const hasEncryptedProperties = this.entries().some(([key]) => {
-      return !!ensure(Config.propertyConfigMap[key]).encrypted;
+      return !!Config.propertyConfigMap[key]?.encrypted;
     });
 
     if (hasEncryptedProperties) {

diff --git a/test/unit/config/configTest.ts b/test/unit/config/configTest.ts
@@ -268,6 +268,15 @@ describe('Config', () => {
 
       expect(writeStub.called).to.be.true;
     });
+
+    it('calls ConfigFile.read with unknown key and does not throw on crypt', async () => {
+      stubMethod($$.SANDBOX, ConfigFile.prototype, ConfigFile.prototype.read.name).callsFake(async function () {
+        this.setContentsFromObject({ unknown: 'unknown config key and value' });
+      });
+
+      const config: Config = await Config.create(Config.getDefaultOptions(true));
+      expect(config).to.exist;
+    });
   });
 
   describe('allowed properties', () => {