feat: add support for refreshing sandboxes #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonnalley
approved these changes
Feb 26, 2024
| this.logger.debug(refreshResult, 'Return from calling tooling.update'); | ||
|
|
||
| if (!refreshResult.success) { | ||
| throw messages.createError('sandboxInfoRefreshFailed', [JSON.stringify(refreshResult)]); |
There was a problem hiding this comment.
is refreshResult guaranteed to be JSON? Just wondering if we get something unexpected back from the server (like HTML) then it would be an ugly message for the user.
There was a problem hiding this comment.
Good question. As long as this uses the jsforce version that catches unexpected HTML responses to SOAP requests it should throw a much better error.
jshackell-sfdc
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
org list.What issues does this PR fix or reference?
@W-15042183@
NOTE: plugin-org tests will fail due to changes in the
SandboxRequestCacheEntrytype. Addedaction.