Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: methods for read/write sfProjectJson.plugins #1094

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

mshanemc
Copy link
Contributor

What does this PR do?

well, this started with

Review JSDoc for class SfProject and SfProjectJson to ensure they are inline with code. Also review examples for correctness.

But then writing correct examples led me to notice how bad of an experience that would be.

So here's 2 new methods to make it simpler (types, etc)

And the jsdoc now reflects their existence.

What issues does this PR fix or reference?

@W-11338906@

@mshanemc mshanemc requested a review from a team as a code owner June 24, 2024 22:24
@shetzel shetzel merged commit ae61aec into main Jun 27, 2024
73 checks passed
@shetzel shetzel deleted the sm/sfProject-plugin-dx branch June 27, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants