Cd/forceignore bug

[cristiand391]

What does this PR do?

Updates the metadata resolver to skip the first forceignore check when resolving components recursively if the dir is a folder.

in the linked GH issue below, when building the component set from the API response SDR is trying checking if unpackaged should be ignored here:

source-deploy-retrieve/src/resolve/metadataResolver.ts

Line 74 in f288319

if (this.forceIgnore?.denies(dir)) {

forceignore.denies will pass a relative path to node-ignore that doesn't have a trailing slash so it is treated as a file when matching the forceignore rules against it:

source-deploy-retrieve/src/resolve/forceIgnore.ts

Line 66 in f288319

return this.parser.ignores(relative(this.forceIgnoreDirectory, fsPath));

What issues does this PR fix or reference?

forcedotcom/cli#2404
@W-13948748@

[cristiand391]

@mshanemc it turns out the bug also affects a real FS tree:

path.relative doesn't return a trailing slash so node-ignore will treat as a file, called here:
https://github.com/forcedotcom/source-deploy-retrieve/blob/f288319e55378d1a7caca5bcd762b77b2c59f30a/src/resolve/forceIgnore.ts#L66C1-L66C1

another option I showed you this morning was to add the trailing slash before passing dir to denies, but then have to remove it again or it will not be able to file the folder in the tree:

source-deploy-retrieve/src/resolve/metadataResolver.ts

Line 78 in f288319

for (const file of this.tree.readDirectory(dir)) {

that also worked, but not sure if it's the right solution:
https://stackoverflow.com/questions/980255/should-a-directory-path-variable-end-with-a-trailing-slash

[mshanemc]

QA notes: using dreamhouse and project:deploy:preview

✅ * ignores everything
✅ !*/ allows all non-directories (everything is still ignored)
✅ !**/classes/** makes all classes show up as "will deploy"

created class Foo in the org via the (eww) dev console per repro.

✅ project retrieve preview shows that it will be retrieved
✅ project retrieve start retrieves the classes and saves them locally to the expected location

Now, let's try to break it

• remove the * options from the forceignore so that the whole project deploys
• change the display test in barcodeScanner.html (lwc)
  ✅ deploy preview shows correct (will deploy lwc)
  ❌ * to ignore everything => throws Error (1): The "path" argument must be of type string. Received undefined

(looks like this is broken in main, not necessarily a bug in this PR)

Note: if you put this back in the .forceignore, it produces the expected results (on both main and this PR)

# First, ignore everything
*

# Now, allow anything that's a directory
!*/

# Then allow anything in the classes directory
!**/lwc/**