Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: catch decoding errors #1167

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix: catch decoding errors #1167

merged 1 commit into from
Nov 9, 2023

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Nov 8, 2023

What does this PR do?

Any errors thrown while looking for decoded keys are handled. Adds a unit test.

What issues does this PR fix or reference?

@W-14457431@
forcedotcom/cli#2560

@shetzel shetzel requested a review from a team as a code owner November 8, 2023 21:39
@shetzel shetzel mentioned this pull request Nov 9, 2023
Closed
@WillieRuemmele
Copy link
Member

QA Notes

✅ commented out the try/catch, and the UT failed

@WillieRuemmele WillieRuemmele merged commit 15f1137 into main Nov 9, 2023
70 checks passed
@WillieRuemmele WillieRuemmele deleted the sh/try-catch-decoding branch November 9, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillieRuemmele WillieRuemmele WillieRuemmele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shetzel @WillieRuemmele @svc-cli-bot