Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: override forceignore defaults #1224

Merged
merged 4 commits into from
Jan 31, 2024
Merged

fix: override forceignore defaults #1224

merged 4 commits into from
Jan 31, 2024

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Jan 30, 2024

What does this PR do?

SDR's was loading its defaults AFTER the user's .forceignore contents. This change switches the order so that users can override the defaults (in this case, NOT ignoring **/.*)

What issues does this PR fix or reference?

@W-14892481@
forcedotcom/cli#2666

QA

by default, files starting with dots are ignored because of DEFAULT_IGNORE.

With this change, you can add !**/.* to your .forceignore and it'll override the defaults.

@mshanemc mshanemc requested a review from a team as a code owner January 30, 2024 18:41
@shetzel shetzel merged commit 954097b into main Jan 31, 2024
69 checks passed
@shetzel shetzel deleted the sm/fix-forceignore-order branch January 31, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants