fix: refactor for better typing and readability #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
approved these changes
Mar 19, 2024
src/client/metadataTransfer.ts
Outdated
| @@ -229,23 +229,34 @@ export abstract class MetadataTransfer< | |||
| await Lifecycle.getInstance().emitWarning('Metadata API response not parseable'); | |||
| return { completed: false }; | |||
| } | |||
| const retryableErrors = [ | |||
There was a problem hiding this comment.
should work. I think this has gotten big/complex enough to make it it separate function (SRP) vs. being inside poll
isRetryable(error: unknown) : boolean and then let it contain the error list and manage the type checks on what it's being passed.
mshanemc
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds 502, 503, and 420 error codes to list of responses to retry during deploy polling.
What issues does this PR fix or reference?
@W-15289218@