fix: from-org refactor #1296
Merged
fix: from-org refactor #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
approved these changes
Apr 23, 2024
Comment on lines
31
to
32
| private connection: Connection; | ||
| private registry: RegistryAccess; |
There was a problem hiding this comment.
could be readonly if we want to
Comment on lines
-166
to
-168
| // The 'singleRecordQuery' method was having connection errors, using `retry` resolves this | ||
| // Note that this type of connection retry logic may someday be added to jsforce v2 | ||
| // Once that happens this logic could be reverted |
| frequency: Duration.milliseconds(1000), | ||
| timeout: Duration.minutes(3), | ||
| poll: async (): Promise<StatusResult> => { | ||
| const res = ensureArray(await this.connection.metadata.list(query)); |
There was a problem hiding this comment.
Have our connections just become more resilient to remove this polling? I don't understand why we're doing this to begin with
There was a problem hiding this comment.
yeah, part of the jsforce stuff that Cristian did jsforce/jsforce#1407.
I think the retry logic was using pollingClient to work around those network issues.
There was a problem hiding this comment.
@WillieRuemmele Shane is correct, I added the pollingClient logic here:
#941
jsforce retries on the same errors that pollingClient and more.
QA Notes
before: sf project generate manifest --from-org test-9flhyhvfmlba@example.com
› Warning: @salesforce/cli update available from 2.36.8 to 2.37.4.
Error (1): _Default: Could not infer a metadata type
Try this:
Additional suggestions:
Confirm the file name, extension, and directory names are correct. Validate against the registry at:
<https://github.com/forcedotcom/source-deploy-retrieve/blob/main/src/registry/metadataRegistry.json>
If the type is not listed in the registry, check that it has Metadata API support via the Metadata Coverage Report:
<https://developer.salesforce.com/docs/metadata-coverage>
If the type is available via Metadata API but not in the registry
- Open an issue <https://github.com/forcedotcom/cli/issues>
- Add the type via PR. Instructions: <https://github.com/forcedotcom/source-deploy-retrieve/blob/main/contributing/metadata.md>✅ : after ➜ ../../oss/plugin-deploy-retrieve/bin/run.js project generate manifest --from-org test-9flhyhvfmlba@example.com
Warning: _Default: Could not infer a metadata type
successfully wrote package.xmlNOTE: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
forcedotcom/cli#2841
@W-15584672@