Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deploy size and count warnings #1435

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Oct 7, 2024

What does this PR do?

Adds a warning when deploy size or deploy file count exceeds a threshold. By default the threshold is 80% of the maximum MDAPI limit.

What issues does this PR fix or reference?

@W-16489032@

To QA:
export DEBUG=sf:MetadataApiDeploy and SF_LOG_LEVEL=debug to see debug output around deploy limits
deploy metadata to a scratch org (dreamhouse-lwc can be used as the project). If you use the --verbose flag it will output the deploy size and count
Override the SF_DEPLOY_SIZE_THRESHOLD env var with different numbers to see changes. 100 or over will disable warnings. 0 will always show warnings. In between, it depends on the amount of metadata being deployed.

@shetzel shetzel requested a review from a team as a code owner October 7, 2024 17:01
@WillieRuemmele
Copy link
Member

QA Notes


✅ : set env, saw warning Warning: Deployment zip file count is approaching the Metadata API limit (10,000). Warning threshold is 1% and count 111 > 100
✅ : set level = 100, no warning
✅ : level = 2, no warning

@WillieRuemmele WillieRuemmele merged commit 3ebdc07 into main Oct 8, 2024
77 checks passed
@WillieRuemmele WillieRuemmele deleted the sh/deploy-size-warn branch October 8, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants