feat: Adds a new metadata bundle type for AppFrameworkTemplates #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! It looks like @rvwatch is an internal user so signing the CLA is not required. However, we need to confirm this. |
rvwatch
commented
Oct 25, 2024
| @@ -4639,6 +4644,49 @@ | |||
| "directoryName": "extlClntAppPushPolicies", | |||
| "inFolder": false, | |||
| "strictDirectoryName": false | |||
| }, | |||
| "appframeworktemplatebundle": { | |||
There was a problem hiding this comment.
I only added this guy. Scripts added the rest.
rvwatch
commented
Oct 25, 2024
src/utils/filePathGenerator.ts
Outdated
| @@ -112,17 +112,26 @@ export const filePathsFromMetadataComponent = ( | |||
|
|
|||
| // lwc, aura, waveTemplate, experiencePropertyType | |||
| if (type.strategies?.adapter === 'bundle') { | |||
| const mappings = new Map<string, string>([ | |||
| const mappings = new Map<string, string | string[]>([ | |||
There was a problem hiding this comment.
I didn't want to mess around with the other bundles, so the only way I could get this to accept my new bundle and still pass the tests was to add the or string[].
rvwatch
commented
Oct 25, 2024
src/utils/filePathGenerator.ts
Outdated
| const matched = mappings.get(type.name); | ||
| if (!matched) { | ||
| throw messages.createError('unsupportedBundleType', [type.name]); | ||
| } | ||
| return [matched]; | ||
|
|
||
| return Array.isArray(matched) ? matched : [matched]; |
There was a problem hiding this comment.
Dealing with my array of strings or strings situation.
Closed
…tead of | string[]
WillieRuemmele
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new metadata bundle type for AppFrameworkTemplates.
What issues does this PR fix or reference?
@W-16928554@
#, @@
Functionality Before
CLI no have AppFrameworkTemplates metadata
<insert gif and/or summary>
Functionality After
CLI now have AppFrameworkTemplates metadata!
<insert gif and/or summary>