Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support for SalesAgreementStatus stdValueSet member #997

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

CristiCanizales
Copy link
Contributor

What does this PR do?

  • Adds SalesAgreementStatus to the StandardValueSetRegistry

What issues does this PR fix or reference?

@W-13520951@

Functionality Before

  • Visual Studio Org browser is not fetching SalesAgreementStatus StandardValueSet

Functionality After

  • Visual Studio Org browser is fetching SalesAgreementStatus StandardValueSet

@CristiCanizales CristiCanizales requested a review from a team as a code owner June 2, 2023 16:34
@randi274
Copy link

randi274 commented Jun 5, 2023

We might have an issue with merging this update into VS Code - SDR bumped up a major version of salesforce/core, and we haven't done that yet. Pete ran into an issue with this and the apex-node library last week. I'll defer to the CLI team on approving this one, and we'll have to make a plan on bumping core in the extensions so we can keep up to date with our internal dependencies.
Screenshot 2023-06-05 at 5 22 42 PM

@gbockus-sf gbockus-sf merged commit 8de0a50 into main Aug 9, 2023
65 checks passed
@gbockus-sf gbockus-sf deleted the cristi/update-stdValueSetRegistry branch August 9, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants