Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support SF_ and SFDX_ prefixed env vars #668

Merged
merged 2 commits into from
Sep 4, 2024
Merged

fix: support SF_ and SFDX_ prefixed env vars #668

merged 2 commits into from
Sep 4, 2024

Conversation

shetzel
Copy link
Collaborator

@shetzel shetzel commented Sep 3, 2024

What does this PR do?

Adds support for:
SFDX_DISABLE_SOURCE_MEMBER_POLLING
SF_DISABLE_SOURCE_MEMBER_POLLING
SFDX_SOURCE_MEMBER_POLLING_TIMEOUT
SF_SOURCE_MEMBER_POLLING_TIMEOUT

Previously, only the SFDX_ prefixed env vars were used.

What issues does this PR fix or reference?

@W-16648418@

@shetzel shetzel requested a review from a team as a code owner September 3, 2024 21:29
@cristiand391
Copy link
Member

QA notes:

setup:
linked this branch of STL to PDR, then linked plugin and did deploys on dreamhouse (had to bump SDR in this PR to get PDR to compile)

✅ SF_ and SFDX_ env vars work for setting polling timeout/disabling poll timeout

@cristiand391 cristiand391 mentioned this pull request Sep 4, 2024
Closed
@cristiand391 cristiand391 merged commit c64812e into main Sep 4, 2024
34 checks passed
@cristiand391 cristiand391 deleted the sh/source_member_polling_timeout branch September 4, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristiand391 cristiand391 cristiand391 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shetzel @cristiand391