Fixed bug with ragged right files #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the length of a line in a file falls short of providing a value for each field (ragged right file), the linePosition can end up equal to the length of the line. This doesn't cause a problem if this is the last field, but does pose a problem if there are additional fields to be checked. On getting the value for the next field the linePosition ends up after the end of the line and throws an exception. The change makes sure that the linePosition is either at or below the end of the line length before trying to start the Substring function. This forces either the NullValue to be returned, or the exception defined a few lines below to be thrown.
|
Thank you @heskethw |
|
No problem! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a small fix for a problem I encountered processing data dump files that were ragged right. These files were in a ragged right format where trailing fields were missing from some lines if no further fields contained data. I have learned this could have been caused if the data dumps were from a Cobol data formatted file (http://tech.wakayos.com/?p=293).
If the length of a line in a file falls short of providing a value for each field (ragged right file), the linePosition can end up equal to the length of the line. This doesn't cause a problem if this is the last field, but does pose a problem if there are additional fields to be checked.
On getting the value for the next field the linePosition ends up after the end of the line and throws an exception. The change makes sure that the linePosition is either at or below the end of the line length before trying to start the Substring function. This forces either the NullValue to be returned, or the exception defined a few lines below to be thrown.