fix: downgrade react-error-overlay to 6.0.9 to fix HMR
#241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic, thank you - I noted this this morning and had scheduled some time in my calendar this afternoon to debug it. So very much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on the map, I noticed that hot module reloads are broken, resulting in the following error on each code change:
After that, the UI becomes unresponsive and I have to F5 the page.
I investigated it a bit and the root cause is a regression in a
react-dev-utilscomponent - see facebook/create-react-app#11771 . Since we are using a lockfile, I downgraded to the previous patch version and HMR is working again.