Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo msrv find --set #1047

Closed
cdown opened this issue Nov 4, 2024 · 2 comments · Fixed by #1049
Closed

cargo msrv find --set #1047

cdown opened this issue Nov 4, 2024 · 2 comments · Fixed by #1049

Comments

@cdown
Copy link
Contributor

cdown commented Nov 4, 2024

One of my usual workflows during dep upgrades is to do cargo msrv find, then cargo msrv set. But this is a pain, because it requires manually copying the new version to cargo msrv set. My workflow would benefit from something like cargo msrv find --set, which would set the found MSRV.

This looks relatively straightforward to implement, but before I submit a PR I wanted to check on the ergonomics and concept. Thanks!

@cdown cdown changed the title cargo msrv --set cargo msrv find --set Nov 4, 2024
@foresterre
Copy link
Owner

foresterre commented Nov 5, 2024

cargo msrv find --write-msrv does this exact thing :)

I would welcome an alias, because similarity in naming between similar options does matter for ease of use.

See

https://github.com/foresterre/cargo-msrv/blob/main/src/cli/mod.rs#L168

@cdown
Copy link
Contributor Author

cdown commented Nov 5, 2024

Oh wow, how did I miss that :-) Thank you! I'll submit a PR for an alias then.

cdown added a commit to cdown/cargo-msrv that referenced this issue Nov 5, 2024
Introduce --set as an alias for the --write-msrv option in `cargo msrv
find' to maintain consistency with `cargo msrv set'.

Closes foresterre#1047.
cdown added a commit to cdown/cargo-msrv that referenced this issue Nov 5, 2024
Introduce --set as an alias for the --write-msrv option in `cargo msrv
find` to maintain consistency with `cargo msrv set`.

Closes foresterre#1047.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants