-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: accept --manifest-path
#412
Comments
Sounds great! I'll add it soon! |
I've tested #420 with Will be included in Output of `cargo hack --workspace msrv verify -- cargo check --all-features`sic on main [$] is 📦 v0.20.0 via 🦀 v1.62.0 took 2s Compatibility Check #1: Rust 1.56.1 info: running Compatibility Check #1: Rust 1.56.1 info: running Compatibility Check #1: Rust 1.56.1 info: running Compatibility Check #1: Rust 1.56.1 info: running Compatibility Check #1: Rust 1.56.1 info: running Compatibility Check #1: Rust 1.56.1 info: running Compatibility Check #1: Rust 1.59.0 info: running Compatibility Check #1: Rust 1.56.1 |
Notably, this will allow cargo-msrv to run under cargo-hack for use in workspaces and to benefit from cargo-hack's detach-from-workspace implementation.
Specifically, I'd love to be able to
cargo hack --workspace minimal-versions msrv verify -- cargo check --all-features
, but this ends up runningcargo msrv verify --manifest-path subcrate\Cargo.toml -- cargo check --all-features
which cargo-msrv then rejects.The desired behavior is fairly simple: retrieve the rust-version key from the given manifest path, and then forward the
--manifest-path
argument to the check invocation.Running under cargo-hack also gives workspace support for free.
The text was updated successfully, but these errors were encountered: