Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put output-format before verify in GitHub Workflow #375

Conversation

KamilaBorowska
Copy link
Contributor

Having verify before --output-format causes the following error:

error: Found argument '--output-format' which wasn't expected, or isn't valid in this context

Having `verify` before `--output-format` causes the following error:

    error: Found argument '--output-format' which wasn't expected,
    or isn't valid in this context
@foresterre
Copy link
Owner

foresterre commented May 28, 2022

Thanks!

Interesting that the program did not return a non-zero exit code.

(Additionally, in the next release (and current main branch), this re-ordering is possible)

@foresterre
Copy link
Owner

bors r+

@codecov
Copy link

codecov bot commented May 28, 2022

Codecov Report

Merging #375 (7aa4db7) into main (3330b4e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #375   +/-   ##
=======================================
  Coverage   51.47%   51.47%           
=======================================
  Files          55       55           
  Lines        1562     1562           
=======================================
  Hits          804      804           
  Misses        758      758           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cc567e...7aa4db7. Read the comment docs.

@bors bors bot merged commit 34750dc into foresterre:main May 28, 2022
foresterre pushed a commit that referenced this pull request Aug 1, 2022
375: Put output-format before verify in GitHub Workflow r=foresterre a=xfix

Having `verify` before `--output-format` causes the following error:

    error: Found argument '--output-format' which wasn't expected, or isn't valid in this context

Co-authored-by: Konrad Borowski <konrad@borowski.pw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants