Add 'minimal' output format #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This output format only reports the final result of a subcommand. If the subcommand fails with an unexpected error, no output may be given, but a failure exit code can still be expected.
Codecov Report
@@ Coverage Diff @@
## main #431 +/- ##
==========================================
+ Coverage 59.86% 60.51% +0.65%
==========================================
Files 76 79 +3
Lines 1744 1811 +67
==========================================
+ Hits 1044 1096 +52
- Misses 700 715 +15
Continue to review full report at Codecov.
|
…result * Renamed outer "Compatibility" struct to "CheckResult" * Moved inner "Compatibility" contents of struct to a shared module, named still as "Compatibility" * Renamed "CompatibilityCheckMethod" to "CheckMethod" for consistency
While 'verify' already kind of outputs its final result by issuing a CheckResult event, and by virtue of it consisting of a single check run, we should also output a final result, even if just for consistency.
…r the minimal output format
|
bors r+ |
This was referenced Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This output format only reports the final result of a subcommand.
If the subcommand fails with an unexpected error, no output may be given,
but a failure exit code can still be expected.
Consider printing oneline errorsMonitoring: if this is desired: please open an issuecloses #370