Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imageproc: add conditional compilation feature #337

Closed
foresterre opened this issue Apr 6, 2020 · 1 comment · Fixed by #410
Closed

imageproc: add conditional compilation feature #337

foresterre opened this issue Apr 6, 2020 · 1 comment · Fixed by #410
Labels
A-image-engine Area: changes related to the image engine
Milestone

Comments

@foresterre
Copy link
Owner

Adding #335 will pull in the full imageproc and rusttype crates.
I would like to add them behind a conditional compilation feature.

To be precise, I would like to add the following optional dependencies and feature to the sic_image_engine crate:

[dependencies]
imageproc = { version = "...", optional = true }
rusttype = { version = "...", optional = true }

[features]
imageproc-operations = [imageproc, rusttype]

Now, if I were to provide the --all-features flag, the imageproc-operations should be set, however if called from the root of the workspace it isn't. I rather not add the same dependencies to the root workspace crate in order to keep the dependencies clean and localized.

Goal: figure out how to enable conditional compilation in a sub crate and propagate the conditional from the root of the workspace

@foresterre foresterre added this to the 0.12.0 milestone Apr 24, 2020
@foresterre foresterre added A-image-engine Area: changes related to the image engine S-in-progress Status: work in progress labels Apr 24, 2020
@foresterre foresterre removed the S-in-progress Status: work in progress label May 20, 2020
@foresterre
Copy link
Owner Author

foresterre commented May 20, 2020

implemented by #410 (see also #395)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-image-engine Area: changes related to the image engine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant