Add imageproc to sic_image_engine behind a conditional compilation feature flag #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With: cargo run --features 'sic_image_engine/imageproc-ops' -- -i resources/1x1_a.png -o target/o.png It now works though; even on stable! yay! Seems that that is regarded as a feature: - rust-lang/cargo#2851 (comment)
…ageproc-features # Conflicts: # Cargo.lock # components/sic_cli/Cargo.toml
foresterre
changed the title
foresterre
added
A-crate-image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features for sub crates are support, but only one package deep from the workspace root package. Since we added imageproc conditionally to our sic_image_engine sub package and used to have the sic_cli crate depend on the sic_image_cli while the root package only contained a main function with a call to sic_cli, we had a package structure two levels deep, thus not being able to use the conditional
sic-image-engine/imageproc-opsfeature transitively.This PR re-integrates the sic_cli crate into the workspace root package, so we can work around this Cargo limitation on conditional compilation.
Future PR's will add similar features for our parsers (i.e. when necessary), and will start implementing actual support for various imageproc operations.
To enable, the crate should be built with
cargo [...] --features "sic-image-engine/imageproc-ops"closes #395