Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docker): fix bcrypt failures in docker container #11

Merged
merged 1 commit into from
Aug 26, 2017

Conversation

forforeach
Copy link
Owner

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests where updated/written
  • Related documents were added

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Sometime the docker container fails with Segmentation failed error. Here is a bug that is opened in bcrypt repo -> Segmentation Fault on Node alpine

What is the new behavior?

Fix the issue by using npm rebuild bcrypt --build-from-source

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@forforeach forforeach self-assigned this Aug 26, 2017
@forforeach forforeach merged commit e285df1 into master Aug 26, 2017
@forforeach forforeach deleted the docker-bcrypt branch August 26, 2017 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant