Make KsuidValue sortable

fork-handles · Sep 18, 2023 · eba9f12 · eba9f12
1 parent 8fb89c2
commit eba9f12
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/values4k/src/main/kotlin/dev/forkhandles/values/ksuid.kt b/values4k/src/main/kotlin/dev/forkhandles/values/ksuid.kt
@@ -6,7 +6,9 @@ import java.time.Clock
 import java.time.Instant
 import java.util.Random
 
-typealias KsuidValue = AbstractValue<Ksuid>
+abstract class KsuidValue(value: Ksuid): AbstractValue<Ksuid>(value), Comparable<KsuidValue> {
+ override fun compareTo(other: KsuidValue) = value.compareTo(other.value)
+}
 
 open class KsuidValueFactory<DOMAIN : Value<Ksuid>>(
  fn: (Ksuid) -> DOMAIN,

diff --git a/values4k/src/test/kotlin/dev/forkhandles/values/KsuidValueTest.kt b/values4k/src/test/kotlin/dev/forkhandles/values/KsuidValueTest.kt
@@ -4,6 +4,7 @@ import com.github.ksuid.Ksuid
 import com.github.ksuid.KsuidGenerator
 import com.natpryce.hamkrest.assertion.assertThat
 import com.natpryce.hamkrest.equalTo
+import com.natpryce.hamkrest.lessThan
 import org.junit.jupiter.api.Test
 import java.time.Clock
 import java.time.Instant
@@ -33,4 +34,11 @@ class KsuidValueTest {
  assertThat(ksuid.instant, equalTo(Instant.parse("2023-09-18T19:08:58Z")))
  assertThat(ksuid.value.toString(), equalTo( "2VaB6tloDoOktDfrzWsjLnnTe9T"))
  }
+
+ @Test
+ fun `compare ids`() {
+ val value1 = MyKsuidValue.parse("2VaFa3DfKMINqSUtdJoTtAMwsHU")
+ val value2 = MyKsuidValue.parse("2VaFcctoWGZV2W7coyJab0p99Sa")
+ assertThat(value1, lessThan(value2))
+ }
 }