Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Add VGLZ1 VERI Gold 1 Ounce token #1687

Merged
merged 8 commits into from
Sep 14, 2018
Merged

Conversation

therealMikkoK
Copy link
Contributor

@therealMikkoK therealMikkoK commented Sep 14, 2018

Copy link
Contributor

@freeatnet freeatnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! Mostly technical changes requested.

---
addr: '0xd1ec43b9d44338a4e74f3f41cd1b86254cbaa874'
decimals: 18
description: >- Tokenized 1 Troy Ounce Gold Bar, Redeemable in Precious Metal (Gold)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description should probably include a bit more info. Eg., see the description in the original request: #1568 (comment)

On the technical side, text after >- should be placed on the next line, indented with 2 spaces, like so:

description: >-
  VGLZ1 is a sub-token of VERI (VERITASEUM) Ecosystem.
  
  VGLZ1 is a digital token asset representing 1oz physical fine .999 gold that can be exchanged
  and then redeemed via the Veritaseum website, or VeADIR Dapp after KYC is provided.

Single line breaks will be converted to a space, two line breaks (or two spaces followed by a line break) will produce a new line (like Reddit comments). (see: https://github.com/forkdelta/tokenbase/blob/master/README.md#description)

# The following options were found #
# You may need to edit them and you MUST delete commented lines #
# From the website: description meta tag #
Veritaseum enables software-driven P2P capital markets without brokerages, banks or traditional exchanges
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template comments (lines that start with #) and the auto-generated description should be deleted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete the template comments

- Blog: https://veritas.veritaseum.com/ve-blog
- Reddit: https://www.reddit.com/r/VeritaseumCommunity/


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra white space here should be deleted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra lines removed

@freeatnet freeatnet force-pushed the therealMikkoK-patch-1 branch from baf6fe7 to 1864a95 Compare September 14, 2018 15:40
Copy link
Contributor

@freeatnet freeatnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@therealMikkoK therealMikkoK merged commit 2b29990 into master Sep 14, 2018
@freeatnet freeatnet deleted the therealMikkoK-patch-1 branch September 21, 2018 14:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants