Do not show symbols from unopened places by default (dotnet#5739)

forki · Oct 5, 2018 · 4529c8f · 4529c8f
1 parent 88ad9d3
commit 4529c8f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/vsintegration/src/FSharp.Editor/Completion/CompletionProvider.fs b/vsintegration/src/FSharp.Editor/Completion/CompletionProvider.fs
@@ -221,7 +221,7 @@ type internal FSharpCompletionProvider
             let! _parsingOptions, projectOptions = projectInfoManager.TryGetOptionsForEditingDocumentOrProject(document)
             let! textVersion = context.Document.GetTextVersionAsync(context.CancellationToken)
             let getAllSymbols(fileCheckResults: FSharpCheckFileResults) =
-                if settings.IntelliSense.ShowAllSymbols
+                if settings.IntelliSense.IncludeSymbolsFromUnopenedNamespacesOrModules
                 then assemblyContentProvider.GetAllEntitiesInProjectAndReferencedAssemblies(fileCheckResults)
                 else []
             let! results = 

diff --git a/vsintegration/src/FSharp.Editor/Options/EditorOptions.fs b/vsintegration/src/FSharp.Editor/Options/EditorOptions.fs
@@ -28,12 +28,12 @@ type EnterKeySetting =
 type IntelliSenseOptions =
   { ShowAfterCharIsTyped: bool
     ShowAfterCharIsDeleted: bool
-    ShowAllSymbols : bool
+    IncludeSymbolsFromUnopenedNamespacesOrModules : bool
     EnterKeySetting : EnterKeySetting }
     static member Default =
       { ShowAfterCharIsTyped = true
         ShowAfterCharIsDeleted = true
-        ShowAllSymbols = true
+        IncludeSymbolsFromUnopenedNamespacesOrModules = false
         EnterKeySetting = EnterKeySetting.NeverNewline}
 
 

diff --git a/vsintegration/src/FSharp.UIResources/IntelliSenseOptionControl.xaml b/vsintegration/src/FSharp.UIResources/IntelliSenseOptionControl.xaml
@@ -25,7 +25,7 @@
                             <CheckBox x:Name="charDeleted" IsEnabled="{Binding IsChecked, ElementName=charTyped}" IsChecked="{Binding ShowAfterCharIsDeleted}"
                         Content="{x:Static local:Strings.Show_completion_list_after_a_character_is_deleted}"/>
                         </StackPanel>
-                        <CheckBox x:Name="showAllSymbols" IsChecked="{Binding ShowAllSymbols}"
+                        <CheckBox x:Name="showAllSymbols" IsChecked="{Binding IncludeSymbolsFromUnopenedNamespacesOrModules}"
                       Content="{x:Static local:Strings.Show_all_symbols}"/>
                     </StackPanel>
                 </GroupBox>