Led grouping and zigzag support #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Output Grouping can be disabled, grouped or zig-zag - Group size specifies the size of groups or zig-zag period (in LEDs, not dmx channels) Its implemented in the pixeldriver so both e.131 and effect data use the grouping config
This was referenced Jan 6, 2019
Closed
Closed
Closed
|
Looking at it now, thanks! I'm thinking if changing it a bit where you can utilize zig-zag and grouping at the same time. Also it still listens to universes based on physical pixels when it should be the virtual / grouped pixels. |
|
I changed it a little bit to where zigzag count and group size are values which are always used. A group of 1 is a single pixel and a zigzag of 0 is no zigzag. Also swapped placeholders for titles in most of the HTML fields for tooltips. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grouping and zig-zag support for ws2811 strips
Its implemented in the pixeldriver so both e.131 and effect data use the grouping config