ParFORM: fix #525 #530
Merged
ParFORM: fix #525 #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
If you are happy with this and merge it, I will look again at the color.h test. |
Redefined variables must be broadcast after processing each expression. Otherwise, the information collected in AC.inputnumbers is wiped out at the beginning of processing the next expression. This fixes form-dev#525.
Collaborator
Author
|
Rebased. I think this is OK to merge (after completing the ongoing CI checks). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #525 by moving the broadcast of the redefined preprocessor variables to after processing each expression, rather than at the end of the module.