build: fix git-version-gen script to use LC_ALL instead of LANG for the locale setting #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace LANG with LC_ALL as the locale setting to ensure consistent date formatting, because LANG can be overridden by LC_TIME or LC_ALL. Also add --date-locale and --date-timezone command line options.
tueda
force-pushed
the
fix-git-version-gen-date
branch
from
1f5dca7 to
8f09300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids partially-broken and ugly date formatting like:
2 command line options, which are nice for debugging, are also added, though they are not used in the build system.