Use par=1 EndSorts in ArgFactorize #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the argument (or a resulting factor) has more than SubTermsInSmall terms, a par=1 EndSort is necessary to avoid a crash here.
tueda
approved these changes
Nov 6, 2024
Collaborator
tueda
left a comment
tueda
left a comment
There was a problem hiding this comment.
Ignoring the whitespace changes, this patch appears to be the minimal set of changes necessary to fix the added test case. I think this PR is ready to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the argument (or a resulting factor) has more than SubTermsInSmall terms, a par=1 EndSort is necessary to avoid a crash here.
Fixes #563