Skip to content

Conversation

@a-maier
Copy link

@a-maier a-maier commented Jun 13, 2025

This adds a test for my series package.

@jodavies
Copy link
Collaborator

(For now) you need to fetch your library file in three different places, for the normal tests, the valgrind tests and the coverage tests.

@jodavies
Copy link
Collaborator

It looks like this is not clean under valgrind... something to investigate already!

@jodavies
Copy link
Collaborator

jodavies@b19ccb4

This fixes the memory leak in your test.

@jodavies
Copy link
Collaborator

If you rebase on master now, the tests should pass

@jodavies
Copy link
Collaborator

jodavies commented Jul 9, 2025

@a-maier if you rebase on master now that #686 is in, and bump the "v1" on the cache name to "v2", it should build a new cache and not fail to wget color.h from nikhef.nl this time.

@coveralls
Copy link

Coverage Status

coverage: 50.874% (+0.001%) from 50.873%
when pulling f15ef8d on a-maier:series-tst
into eebd42d on form-dev:master.

@jodavies
Copy link
Collaborator

Great, thanks for the extra tests!

@jodavies jodavies merged commit bbd9a7e into form-dev:master Jul 10, 2025
84 checks passed
@jodavies
Copy link
Collaborator

Ah -- somewhere, this coverage runs for the extra tests got messed up. There is a double "--timeout" arg given to check.rb, and it does not run any of them. I'll prepare a fix...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants