Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add workflow run trigger event dimension to workflow_status_cou… #9

Merged
merged 1 commit into from
Jan 10, 2024
Merged

feat: add workflow run trigger event dimension to workflow_status_cou… #9

merged 1 commit into from
Jan 10, 2024

Conversation

przechrzta-f3
Copy link

@przechrzta-f3 przechrzta-f3 commented Jan 9, 2024 •
edited
Loading

Description

This pull request adds additional dimension trigger_event to workflow_status_count{} metric

Context: ticket

Proof of work

By running locally and collecting metrics after consuming events from test repository. Metrics are collected and new dimension trigger_event is reported:
edited-exporter-test

@przechrzta-f3 przechrzta-f3 requested a review from a team as a code owner January 9, 2024 12:19
@przechrzta-f3 przechrzta-f3 merged commit 7ecb760 into main Jan 10, 2024
2 checks passed
@przechrzta-f3 przechrzta-f3 deleted the wp-expose-worklow-trigger branch January 10, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojciecholszewski-form3 wojciecholszewski-form3 wojciecholszewski-form3 approved these changes

@mikolaj-krzyzanowski-f3 mikolaj-krzyzanowski-f3 mikolaj-krzyzanowski-f3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@przechrzta-f3 @wojciecholszewski-form3 @mikolaj-krzyzanowski-f3